Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_transaction_fee to playbook #1109

Conversation

cluster
Copy link
Contributor

@cluster cluster commented Jun 19, 2023

Description

This PR updates the playbook to add a new function that gets the transaction fee for archethic-foundation/smart-contract-playground#17

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally

@cluster cluster self-assigned this Jun 19, 2023
@bchamagne
Copy link
Member

I don't get why the playground is using Playbooks.

@cluster
Copy link
Contributor Author

cluster commented Jun 20, 2023

It was convenient to have an already made client to access the blockchain 🙃

@bchamagne
Copy link
Member

As discussed, #994 will move this into a Api module. And maybe this Api module will be moved.

@bchamagne bchamagne added this to the 1.3.0 milestone Jun 20, 2023
@cluster cluster force-pushed the add_get_transaction_fee_to_playbook branch from 622ad27 to 727da0a Compare June 20, 2023 11:37
@bchamagne bchamagne modified the milestones: 1.3.0, 1.2.4 Jun 30, 2023
@cluster cluster force-pushed the add_get_transaction_fee_to_playbook branch from 727da0a to 0380ad7 Compare June 30, 2023 17:00
@samuelmanzanera samuelmanzanera added enhancements smart contracts Involve smart contracts labels Jul 6, 2023
@bchamagne bchamagne changed the base branch from develop to playground July 6, 2023 15:03
@bchamagne bchamagne force-pushed the add_get_transaction_fee_to_playbook branch from 0380ad7 to 628d706 Compare July 6, 2023 15:09
@bchamagne bchamagne force-pushed the add_get_transaction_fee_to_playbook branch from 628d706 to 40ec1f9 Compare July 6, 2023 15:12
@bchamagne bchamagne merged commit f4e52b5 into archethic-foundation:playground Jul 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements smart contracts Involve smart contracts
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

None yet

3 participants